-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to disable default tags #1141
Comments
Hi @mikael-lindstrom, And the option you are suggesting is a new feature which you can use while provisioning the resource at runtime, to disable the default tagging. What happens when you use the vanilla |
Hi @ulucinar, That is correct, Scality supports most S3 functionality and if I disable the default tags everything works great. I have a fork we are using which only comments out the line I mentioned above here. If I just use the AWS CLI to try an tag a bucket Scality returns $ aws s3api put-bucket-tagging --bucket my-test-bucket --tagging 'TagSet=[{Key=test,Value=test}]'
An error occurred (NotImplemented) when calling the PutBucketTagging operation: A header you provided implies functionality that is not implemented. If there was an option to disable the default tags we would be able to switch to the vanilla provider and not maintain our own fork. I know there are other S3-compatible services which does not support bucket tags so I think this would be useful feature. |
This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as |
This issue is being closed since there has been no activity for 14 days since marking it as |
This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as |
This issue is being closed since there has been no activity for 14 days since marking it as |
/reopen |
What problem are you facing?
We are using a S3 compatible service called Scality Ring. It supports most S3 functionality, however it does not support tags which causes a problem with this provider since it sets three tags by default:
The tags seems to be set by the
AddExternalTagsField
function which adds aTagger
if the resource supports tags and there is no way to disable this. I have made a fork and built a custom version based on the v1.0.0 release where I simply commented outAddExternalTagsField
from thewithDefaultResourceOptions
here. We are now using this version in our clusters which works great.How could Official AWS Provider help solve your problem?
By providing an option to disable the "default" crossplane tags the provider would work with more S3 compatible services. I would be happy to help with implementing this but I'm not familiar enough with the codebase to know how this should be implemented.
The text was updated successfully, but these errors were encountered: