-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for skipping default tags #1474
base: main
Are you sure you want to change the base?
Add options for skipping default tags #1474
Conversation
Signed-off-by: Mikael Lindström <[email protected]>
6fe2478
to
f14d9f8
Compare
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
This pull request is being closed since there has been no activity for 14 days since marking it as |
/reopen |
Would really like this feature, as the "S3-compatible" Cloudian also does not support tags on IAM Policy and User. |
If it's not possible to get this option into the provider config without severe drawbacks, it LGTM! |
@turkenf Any advice on how to get progress on this PR? As a workaround we are currently using the "old" AWS provider for the problematic managed not supporting tags in our S3 "compatible" infrastructure (Cloudian), but this setup seems to "hit the roof" in number of CRDs in our cluster. So we would have no other choice than to fork this provider, which is something we obviously would like to avoid.... 😄 |
Description of your changes
The PR introduces the argument
--skip-default-tags
which makes the provider skip setting the default tags:This is useful for "S3-compatible" services such as Scality Ring which implements all the required API for Crossplane except for tags. Currently the provider fails to create a bucket in Scality Ring since the tag API returns
501 NotImplemented
.Unfortunately this introduces changes to a lot of generated files since
hack/main.go.tmpl
is modified but the change is small. Unsure if there is a better way to solve this.Fixes #1141
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
This has been tested against localstack and works as previously without
--skip-default-tags
, when it's set it correctly skips setting the default crossplane tags for S3 buckets.We are running this change in production for a week now and it's working fine with the option
--skip-default-tags
added to theDeploymentRuntimeConfig
against Scality Ring which does not support tags.