-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow provider listener ports to be configurable #1524
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: ravilr <[email protected]>
I'm marking this PR as "blocked" while we wait for upstream resolution of crossplane/crossplane#5540 |
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
/fresh |
Hi @jeanduplessis @turkenf the crossplane core changes to support configurable ports for the provider runtime is now merged. Can you please take a look at this. |
@ravilr thanks for the ping, we'll keep this one in mind when we prepare for the next minor release of the provider. |
Description of your changes
Part of crossplane/crossplane#5520
As outlined in the above issue, when running Crossplane in certain environments (like EKS using Calico CNI/Cilium in overlay network), where the control plane resides outside the workload network it is necessary to run webhooks in the host network. This calls for the need to make the listening ports(webhook and metrics) of provider controllers configurable to avoid port conflicts among different provider families pods.
I have:
make reviewable
to ensure this PR is ready for review.[ ] Addedbackport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
DeploymentRuntimeConfig
, and verified that a provider launched with these new flags with custom ports and correspondingDeploymentRuntimeConfig
, had conversion webhook communications working without errors.