-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aws_sagemaker_mlflow_tracking_server resource #1564
Conversation
e7ece3b
to
08496b3
Compare
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
2 similar comments
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
@turkenf do you mind running the tests again? The error may have been transient, doesn't look code related |
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
@Ezzmo It looks like the provider pod logs have some info on errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5ff8a59
to
835d924
Compare
Thanks @turkenf , I missed those (oops) I've updated the references for the related role and policy, fixed the S3 reference and some metadata mistakes |
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
@turkenf Looks like it needs another run |
config/externalname.go
Outdated
@@ -2281,6 +2281,8 @@ var TerraformPluginSDKExternalNameConfigs = map[string]config.ExternalName{ | |||
"aws_sagemaker_image": config.ParameterAsIdentifier("image_name"), | |||
// SageMaker Code Images can be imported using the name | |||
"aws_sagemaker_image_version": config.IdentifierFromProvider, | |||
// Sagemaker MLFlow tracking server can be imported using the name | |||
"aws_sagemaker_mlflow_tracking_server": config.NameAsIdentifier, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To use NameAsIdentifier
as an external name, the resource must be imported with the name, and the name argument must be present. See https://github.com/crossplane/upjet/blob/main/docs/adding-new-resource.md#case-1-name-as-identifier
When I look at the resource's import document, it says that it can be imported with workteam_name
. I assume there is a mistake here and that is because I don't see an argument called workteam_name
. Instead, tracking_server_name
can be used, and in this case, the most appropriate external name configuration is ParameterAsIdentifier.
Could you please regenerate the resource with the following configuration?
"aws_sagemaker_mlflow_tracking_server": config.NameAsIdentifier, | |
"aws_sagemaker_mlflow_tracking_server": config.ParameterAsIdentifier("tracking_server_name"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the mistake of thinking id
was acceptable for NameAsIdentifier
Thanks @turkenf. I've updated
a939d29
to
f957e6c
Compare
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
1 similar comment
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" |
Signed-off-by: Ezzmo <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
…tionDetails Signed-off-by: Tim Birkett <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Tim Birkett <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Tim Birkett <[email protected]> Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: root <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Fatih Türken <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Fatih Türken <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Fatih Türken <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Fatih Türken <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Fatih Türken <[email protected]> Signed-off-by: Ezzmo <[email protected]>
Signed-off-by: Ezzmo <[email protected]>
927082c
to
624bc2a
Compare
@turkenf Thanks for helping in the Slack channel. Tests ran successfully finally after increasing the timeout.
Hopefully will run successfully here |
/test-examples="examples/sagemaker/v1beta1/mlflowtrackingserver.yaml" https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/12280429287 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for all your efforts @Ezzmo, the PR looks good to me, except for the commit history :) If you have time, it would be great to squash your commits to keep the commit history clean.
Signed-off-by: Tim Birkett <[email protected]>
Signed-off-by: Tim Birkett <[email protected]>
@turkenf Rebasing this is proving very hairy, I'm going to produce a new branch with a new PR with a single commit to clean this all up. I suspect the way I updated my feature branch has caused problems now. |
Description of your changes
This PR adds the
mlflowtrackingservers.sagemaker.aws.upbound.io
resourceI have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
I tested locally with uptest. The MlFlow tracking server created successfully and tasks succeeded