Skip to content

adds using secrets in a python function and cli --function-credentials #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

fabricebrito
Copy link

This PR adds documentation on how to use secrets in Python functions and extends the crossplane render --function-credentials=PATH cli

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 544508c
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/67ebf829e23b3c000821b7bf
😎 Deploy Preview https://deploy-preview-902--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🔴 down 20 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@fabricebrito
Copy link
Author

@negz
Copy link
Member

negz commented Mar 28, 2025

Nice work! Thank you.

@negz
Copy link
Member

negz commented Mar 28, 2025

@fabricebrito Can you sign your git commit please - we need that before we can merge.

See https://github.com/crossplane/docs/pull/902/checks?check_run_id=39578510287 for context.

(git commit --amend -s should do it.)

@fabricebrito
Copy link
Author

@negz the commit is now signed

@negz
Copy link
Member

negz commented Apr 1, 2025

@fabricebrito Sadly it seems like the commits aren't signed - the DCO check is still failing.

@jbw976
Copy link
Member

jbw976 commented Apr 1, 2025

@fabricebrito something odd is going on in the history of your branch it seems like. I see multiple merge commits and some of my previous commits from #900 seem to be in your branch's history now too 🤔

Screenshot 2025-04-01 at 7 35 46 PM

Have you looked into using a git rebase workflow? Since I started doing that years ago, I have largely avoided any messy branch history - I've never looked back since adopting it 😂
https://simondosda.github.io/posts/2022-01-03-git-rebase-workflow.html

From the DCO check:

There are 4 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

All the commits in the branch must be signed off. I'm not quite sure what has happened in your branch, but it may be reasonable for you to start fresh and apply just your final changes (with a sign-off), instead of trying to continue cleaning things up.

@fabricebrito
Copy link
Author

I'm sorry for the mess. I'll start fresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants