-
Notifications
You must be signed in to change notification settings - Fork 139
Document the ImageConfig path rewriting feature in Crossplane 1.20 #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c1ece7a
to
c499786
Compare
While we're here, move the common content on matching and debugging to their own top-level headings, since they apply to all the different ImageConfig features. Signed-off-by: Adam Wolfe Gordon <[email protected]>
c499786
to
67143ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @adamwg, thanks for writing up such helpful information about the image rewriting feature you built! 🙌
This also should be copied to /content/master
so it's applicable there too, and then just one small suggestion for you to consider beyond that. Thank you!
### Interaction with other operations | ||
|
||
Image rewriting is always done before other `ImageConfig` operations. If you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems pretty important for folks to know, consider putting it into a "hint - tip" box to help it stand out a bit more. details on how to use them are in https://docs.crossplane.io/contribute/features/#hints-and-alert-boxes.
@@ -10,6 +10,35 @@ description: "Image Configs is an API for centralized control of the configurati | |||
Crossplane package images. It allows you to configure package manager behavior | |||
for images globally, without needing to be referenced by other objects. | |||
|
|||
## Matching image references |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature is also in master
builds, so the same changes should be copied to /content/master
as well. This docs repo does not use git branches for the different versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Signed-off-by: Adam Wolfe Gordon <[email protected]>
Signed-off-by: Adam Wolfe Gordon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @adamwg, thanks for this contribution! 🎉
While we're here, move the common content on matching and debugging to their own top-level headings, since they apply to all the different ImageConfig features.