Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move organizationName to CrowdinProviderConfig #233

Merged
merged 8 commits into from
Oct 27, 2023
Merged

Conversation

serhii-londar
Copy link
Collaborator

@serhii-londar serhii-londar commented Oct 16, 2023

Closes #223

Update Languages API to support organization name.
Rebuild some dependencies affected by moving organizationName to CrowdinnProviderConfig.
Add organizationName to all initialisers where needed.
@crowdin-bot
Copy link
Collaborator

crowdin-bot commented Oct 16, 2023

Warnings
⚠️ Big PR, try to keep changes smaller if you can

Generated by 🚫 Danger Swift against 886d333

@andrii-bodnar
Copy link
Member

Please update the documentation as well:

The organization name is configurable through the crowdinProviderConfig. We need to show only this way of configuration.

@andrii-bodnar andrii-bodnar changed the title #223 feat: Move organizationName to CrowdinnProviderConfig Oct 16, 2023
@andrii-bodnar andrii-bodnar changed the title feat: Move organizationName to CrowdinnProviderConfig feat: Move organizationName to CrowdinnProviderConfig Oct 16, 2023
@andrii-bodnar andrii-bodnar changed the title feat: Move organizationName to CrowdinnProviderConfig feat: Move organizationName to CrowdinProviderConfig Oct 16, 2023
Update Languages API to support organization name.
Rebuild some dependencies affected by moving organizationName to CrowdinnProviderConfig.
Add organizationName to all initialisers where needed.
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #233 (776f113) into master (f5818ed) will decrease coverage by 0.21%.
Report is 2 commits behind head on master.
The diff coverage is 78.49%.

❗ Current head 776f113 differs from pull request most recent head 886d333. Consider uploading reports for the commit 886d333 to get more accurate results

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   60.80%   60.59%   -0.21%     
==========================================
  Files         123      123              
  Lines        4561     4559       -2     
==========================================
- Hits         2773     2762      -11     
- Misses       1788     1797       +9     
Files Coverage Δ
Sources/CrowdinSDK/CrowdinAPI/CrowdinAPI.swift 55.68% <100.00%> (ø)
...CrowdinAPI/DistributionsAPI/DistributionsAPI.swift 100.00% <100.00%> (ø)
...rces/CrowdinSDK/CrowdinAPI/LoginAPI/LoginAPI.swift 74.33% <100.00%> (ø)
...urces/CrowdinSDK/CrowdinSDK/CrowdinSDKConfig.swift 100.00% <ø> (ø)
...SDK/Features/LoginFeature/CrowdinLoginConfig.swift 100.00% <100.00%> (ø)
...res/LoginFeature/Extensions/CrowdinSDK+Login.swift 33.34% <100.00%> (ø)
...ginFeature/Extensions/CrowdinSDKConfig+Login.swift 100.00% <ø> (ø)
...rowdinSDK/Features/LoginFeature/LoginFeature.swift 25.00% <100.00%> (ø)
...oviders/Crowdin/Config/CrowdinProviderConfig.swift 64.29% <100.00%> (+2.75%) ⬆️
.../Extensions/CrowdinSDKConfig+CrowdinProvider.swift 100.00% <100.00%> (ø)
... and 19 more

@andrii-bodnar andrii-bodnar merged commit 4723007 into master Oct 27, 2023
7 checks passed
@andrii-bodnar andrii-bodnar deleted the #223 branch October 27, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"es" (spanish) translations are not working properly.
3 participants