Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Add additional ssl options to db configuration #3387

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LaurenceJJones
Copy link
Contributor

This PR adds option for user to configure CACert , ClientCert and ClientKey to be used within the database connection strings, this will allow users to configure CA more easily by providing a path and also the ability to use client authentication measures.

Need to test the following:

  • Postgres
  • Mysql
  • Mariadb

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area agent

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 58.59%. Comparing base (5c0c4f9) to head (676a12e).

Files with missing lines Patch % Lines
pkg/csconfig/database.go 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3387      +/-   ##
==========================================
- Coverage   58.63%   58.59%   -0.04%     
==========================================
  Files         356      356              
  Lines       38215    38230      +15     
==========================================
- Hits        22406    22400       -6     
- Misses      13895    13915      +20     
- Partials     1914     1915       +1     
Flag Coverage Δ
bats 41.60% <0.00%> (-0.03%) ⬇️
unit-linux 33.09% <0.00%> (-0.03%) ⬇️
unit-windows 28.40% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants