Basic Windows support (trough PEAK-System PCAN-USB driver) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed some typos - Switched to using promises on some places - Bumped ESLint to ECMAScript 8 as it is supported by Node 12+ and my changes benefit from it (async methods in classes)
|
Thank you for this PR! I'll check and test this during the next week. Can you please merge the changes (dependency updates) I've made yesterday? Some thoughts for now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it on Windows 11 with installed PEAK-System USB driver, this CAN<>USB adapter, MCP2515 CAN module and Arduino Pro Mini (ATMega328PB) board with your
mcp-can-bootbootloader.Can you please test it on Linux, if the functionality is same as before? I am unable to test it right now.