-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reports): use S3 presigned URL for archived recording reports #856
Open
andrewazores
wants to merge
3
commits into
cryostatio:main
Choose a base branch
from
andrewazores:reports-presign-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR/issue depends on: |
7 tasks
e134fd7
to
0dcd194
Compare
currently unused
/build_test |
Workflow started at 3/21/2025, 3:06:55 PM. View Actions Run. |
No OpenAPI schema changes detected. |
No GraphQL schema changes detected. |
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Replaces #270
Depends on cryostatio/cryostat-reports#200
Related to #269
Description of the change:
See cryostatio/cryostat-reports#200 and #269. This adds a configuration property to control whether this new behaviour is used, and it is enabled by default.
The new behaviour uses the S3 object storage's presigned GET download URLs capability to allow the report generator to retrieve the JFR recording files on its own, rather than Cryostat needing to act as a piping intermediary.
The original implementation in #270 would also handle active recordings in the same way by first creating a transient archived recording copy for these purposes, but this does not reduce overall network traffic or latency and leads to many more potential transient recording copies polluting the storage, so I dropped that idea in this reimplementation. Report requests for active recordings will always use the intermediary pipe method, but requests for archived recordings will use presigned URLs for transfers by default if sidecar report generation is also enabled.
How to manually test:
./smoketest.bash -Or
podman logs -f compose_reports_1
andpodman logs -f compose_cryostat_1
to watch the logs