Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Added Progressbar Base Component #298

Closed
wants to merge 18 commits into from
Closed

Added Progressbar Base Component #298

wants to merge 18 commits into from

Conversation

ClientCrash
Copy link
Member

@ClientCrash ClientCrash commented Oct 15, 2021 •
edited
Loading

This pr uses divs because styling of the progress element isnt supported in all browsers. At least to the extend needed for this component.

  • Display Progressbar
  • Progressbar should display the correct value.
    Closes Progressbar #286

@ClientCrash
Copy link
Member Author

@MarcelCoding @MaxiHuHe04

@Tristan-H11 Tristan-H11 changed the base branch from master to issue/260-base-components March 6, 2022 10:27
Tristan-H11
Tristan-H11 suggested changes Mar 6, 2022
View reviewed changes
Copy link
Member

@Tristan-H11 Tristan-H11 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this v2-prefix really necessary?

src/app/design/progressbar/progressbar.component.html Outdated Show resolved Hide resolved
src/app/design/progressbar/progressbar.component.html Outdated Show resolved Hide resolved
src/app/design/progressbar/progressbar.component.scss Outdated Show resolved Hide resolved
src/app/design/progressbar/progressbar.component.scss Outdated Show resolved Hide resolved
@MarcelCoding MarcelCoding force-pushed the issue/260-base-components branch from ee25cf8 to 5724890 Compare March 6, 2022 11:10
@MarcelCoding MarcelCoding force-pushed the issue/260-base-components branch from 5724890 to 26676a9 Compare March 6, 2022 11:12
MarcelCoding
MarcelCoding suggested changes Mar 9, 2022
View reviewed changes
src/app/design/progressbar/progressbar.component.html Show resolved Hide resolved
src/app/app.module.ts Outdated Show resolved Hide resolved
@MarcelCoding MarcelCoding force-pushed the issue/260-base-components branch from 26676a9 to 37e5729 Compare March 14, 2022 17:35
@Tristan-H11 Tristan-H11 added this to the v0.3.0-pre-alpha milestone Mar 16, 2022
@Tristan-H11 Tristan-H11 linked an issue Mar 16, 2022 that may be closed by this pull request
Progressbar #286
Closed
@Tristan-H11 Tristan-H11 force-pushed the issue/260-base-components branch from 87237a5 to 7cc9f7b Compare March 21, 2022 19:57
Tristan-H11
Tristan-H11 previously approved these changes Mar 21, 2022
View reviewed changes
src/app/design/progressbar/progressbar.component.ts Outdated Show resolved Hide resolved
@Tristan-H11 Tristan-H11 dismissed their stale review March 23, 2022 13:18

outdated

@ClientCrash
moved ProgressBarComponent from app module to design module
c8d0047
@ClientCrash
Squashed commit of the following:
cf0c11e 
commit 86df925
Author: Tristan-H11 <[email protected]>
Date:   Wed Mar 23 16:03:41 2022 +0100

    Fixed button colors. (#279)

commit e330e27
Author: Tristan-H11 <[email protected]>
Date:   Wed Mar 23 12:13:47 2022 +0100

    Added Jost and set default size to 20px. (#260)

commit 9c6950a
Author: Tristan-H11 <[email protected]>
Date:   Wed Mar 23 11:50:49 2022 +0100

    Cloudflare trigger.

commit 07e2f63
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 20:21:57 2022 +0100

    Improved Base-Components showcase page. (#260)

commit a05098a
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 19:43:12 2022 +0100

    Moved Buttons into buttons-dir and fixed some paddings. (#279)

commit 58a1134
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:50:07 2022 +0100

    Added text-only button. (#279)

commit 1a10220
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:31:34 2022 +0100

    Added cursor-behaviour. (#279)

commit a798dc7
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:29:29 2022 +0100

    Added outline-buttons. (#279)

commit 7724400
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:29:09 2022 +0100

    Fixed Fontsize. (#260)

commit 1a729fe
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:28:37 2022 +0100

    Grouped colors. (#260)

commit 56ddecf
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:02:53 2022 +0100

    Fixed background. (#358)

commit 140f93a
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:02:18 2022 +0100

    Set new radius for the button. (#260)

commit 2ccb1ff
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 16:01:55 2022 +0100

    Added the color-variables for fonts, backgrounds and popUps. (#260)

commit 2a71c44
Author: Tristan-H11 <[email protected]>
Date:   Tue Mar 22 15:37:13 2022 +0100

    Changes ES-Lint to allow the "design"-prefix in the component-selector.

commit 95b487f
Author: Tristan-H11 <[email protected]>
Date:   Mon Mar 21 21:49:51 2022 +0100

    Fixed design-button being animated while disabled.

commit 7ec4ae7
Author: Tristan-H11 <[email protected]>
Date:   Mon Mar 21 21:49:31 2022 +0100

    Added testing page for design-button. (#358)

commit 71178d1
Author: Tristan-H11 <[email protected]>
Date:   Mon Mar 21 21:23:13 2022 +0100

    Renamed button to "design-button".

commit 7cc9f7b
Author: Tristan-H11 <[email protected]>
Date:   Mon Mar 21 20:11:39 2022 +0100

    Creates Base-Components-Page with lazy-loading. (#358)

commit 428be30
Author: Marcel <[email protected]>
Date:   Mon Mar 14 18:33:42 2022 +0100

    Fixed merge conflicts

commit c69a13d
Author: ClientCrash <[email protected]>
Date:   Sun Mar 6 11:20:17 2022 +0100

    Added Button Base Component (#275)

commit 529d501
Author: Marcel <[email protected]>
Date:   Mon Mar 14 18:33:42 2022 +0100

    Fixed merge conflicts

commit e89f955
Author: ClientCrash <[email protected]>
Date:   Sun Mar 6 11:20:17 2022 +0100

    Added Button Base Component (#275)

commit 23d7599
Author: Tristan-H11 <[email protected]>
Date:   Mon Mar 21 20:54:14 2022 +0100

    Fixed NG01002 in settings.component.ts.

commit cde63f5
Author: Marcel <[email protected]>
Date:   Mon Mar 21 19:10:33 2022 +0100

    Added some tags for sentry (#356)

commit ed219e9
Author: Marcel <[email protected]>
Date:   Mon Mar 21 11:52:35 2022 +0100

    Added sentry (#354)

commit 7abb2f2
Author: Marcel <[email protected]>
Date:   Fri Mar 18 23:01:45 2022 +0100

    Handle inconsistencies in backend (#355)

    The python backend sends errors inside of data and not in the root of the json.

commit 3326564
Author: Tristan <[email protected]>
Date:   Thu Mar 17 11:21:56 2022 +0100

    Terminal history now shows invalid commands. (#351) (#353)

    * Terminal history now shows invalid commands. (#351)

    * Improved command trimming (#351)

    * Terminal history now shows invalid commands. (#351)

    * Improved command trimming (#351)

    Co-authored-by: ClientCrash <[email protected]>

commit e6c4d58
Author: Marcel <[email protected]>
Date:   Wed Mar 16 13:22:26 2022 +0100

    Migraded to number pipes for i18n valid formatting (#352)

commit 373541e
Author: Marcel <[email protected]>
Date:   Sun Mar 13 14:14:40 2022 +0100

    Fixed colors in some desktop apps (#344)

commit 719722e
Author: Marcel <[email protected]>
Date:   Wed Mar 9 20:20:48 2022 +0100

    Added @angular/localize (#341)

commit 0a37dbd
Author: Marcel <[email protected]>
Date:   Tue Mar 8 14:37:59 2022 +0100

    Added background color as fallback while loading (#339)

commit a6de007
Author: Marcel <[email protected]>
Date:   Tue Mar 8 12:17:22 2022 +0100

    Splited AppModule into lazy-loaded modules (#338)

commit 438f700
Author: McModknower <[email protected]>
Date:   Tue Mar 8 10:20:57 2022 +0000

    Fixed history command display order (#335)

commit c89309c
Author: Marcel <[email protected]>
Date:   Tue Mar 8 10:56:33 2022 +0100

    Browsers without service worker support cannot open the game

commit e0e93ad
Author: Marcel <[email protected]>
Date:   Tue Mar 8 10:25:25 2022 +0100

    Updated @typescript-eslint/* to v5.14.x

commit 4fe977c
Author: McModknower <[email protected]>
Date:   Mon Mar 7 23:06:12 2022 +0100

    Use single quotes

commit d2e6666
Author: McModknower <[email protected]>
Date:   Mon Mar 7 23:00:51 2022 +0100

    Fix history not storing args (#332)

commit 0b295bd
Author: Tristan <[email protected]>
Date:   Sun Mar 6 13:10:33 2022 +0100

    Removal of service worker
@ClientCrash ClientCrash closed this Apr 2, 2022
@ClientCrash ClientCrash deleted the base-components-Progressbar branch April 2, 2022 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tristan-H11 Tristan-H11 Tristan-H11 left review comments

@MarcelCoding MarcelCoding MarcelCoding requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Alpha v1.0.0
Development

Successfully merging this pull request may close these issues.

Progressbar
3 participants
@ClientCrash @MarcelCoding @Tristan-H11