Merge pull request #81 from steveluscher/this-but-faster

Improve decoding performance
cryptocoinjs · Jul 4, 2024 · 64e196c · 64e196c
2 parents 39f2673 + 261fb36
commit 64e196c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/cjs/index.cjs b/src/cjs/index.cjs
@@ -81,7 +81,7 @@ function base (ALPHABET) {
     const size = (((source.length - psz) * FACTOR) + 1) >>> 0 // log(58) / log(256), rounded up.
     const b256 = new Uint8Array(size)
     // Process the characters.
-    while (source[psz]) {
+    while (psz < source.length) {
       // Decode character
       let carry = BASE_MAP[source.charCodeAt(psz)]
       // Invalid character

diff --git a/src/esm/index.js b/src/esm/index.js
@@ -79,7 +79,7 @@ function base (ALPHABET) {
     const size = (((source.length - psz) * FACTOR) + 1) >>> 0 // log(58) / log(256), rounded up.
     const b256 = new Uint8Array(size)
     // Process the characters.
-    while (source[psz]) {
+    while (psz < source.length) {
       // Decode character
       let carry = BASE_MAP[source.charCodeAt(psz)]
       // Invalid character

diff --git a/ts_src/index.ts b/ts_src/index.ts
@@ -100,7 +100,7 @@ function base (ALPHABET: string): base.BaseConverter {
     const b256 = new Uint8Array(size)
 
     // Process the characters.
-    while (source[psz]) {
+    while (psz < source.length) {
       // Decode character
       let carry = BASE_MAP[source.charCodeAt(psz)]