Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting enabled by default #642

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy-book.yml
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@ jobs:
- name: Populate sample version of Crystal
run: crystal --version | tee crystal-version.txt
- name: Build book
run: LINT=true make build
run: make build
- name: Configure AWS Credentials
if: github.event_name == 'push' && steps.branch.outputs.branch != null && github.repository == 'crystal-lang/crystal-book'
uses: aws-actions/configure-aws-credentials@v1
2 changes: 1 addition & 1 deletion mkdocs.yml
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ plugins:
governance.md: https://crystal-lang.org/community/governance
platform_support.md: syntax_and_semantics/platform_support.md
- code-validator:
enabled: !ENV [LINT, false]
enabled: !ENV [LINT, true]
identifiers:
crystal:
validators:
2 changes: 2 additions & 0 deletions netlify.toml
Original file line number Diff line number Diff line change
@@ -4,3 +4,5 @@
command = "mkdocs build -d site --strict"
publish = "site/"

[context.deploy-preview.environment]
LINT = "false"