Skip to content

Use Process.exec in shards run #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

straight-shoota
Copy link
Member

Resolves #685

@beta-ziliani
Copy link
Member

Just noting that tests are failing

@straight-shoota
Copy link
Member Author

We're stopping execution of the current program with exec directly after emitting the last log message. Because of that, the async log dispatcher doesn't run anymore and the message never gets written.

For now I'm adding a patch to explicitly close the log backend, which flushes all pending message.

But this seems like a general problem that should be addressed in the Crystal repo.

@straight-shoota
Copy link
Member Author

The failure on Windows is due to crystal-lang/crystal#14422
So apparently we cannot use Process.exec on Windows just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shards run cannot handle all exit statuses
3 participants