AUTH, Message-Size, STARTTLS, encoding, "firewall" #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual Threads support. enh: Use ExecutorService for handling new connections. enh: Message size limitation.
…ual Threads support. enh: Use ExecutorService for handling new connections. enh: Message size limitation.
|
Hi @imario42, Thanks for your contribution. Your PR seems amazing with a lot of features ! There sure are some very interesting ideas, but as you stated, there is a lot of modifications in many ways and that make this PR unmergeable. It would be amazing if you could implement AUTH and STARTTLS in two separates PR. Please also note that I want to maintain JDK11 compatibility. |
add LOGIN auth type.
add LOGIN auth type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Cédric!
I forked your library and implemented some things so I can maybe use it as an in-house SMTP sink.
Unfortunately this somehow went out of control and the PR is very comprehensive and also contains some layout changes which I probably should have avoided. Sorry for that.
Beware: Beside that I also updated the pom.xml to deploy via the Maven Central Publisher under my group id.
This definitely needs to be undone.
Said that, I would perfectly understand if you do not want to merge that beast yet (or never).
I will stay on my fork until I know that it works as expected in PROD.