-
Notifications
You must be signed in to change notification settings - Fork 12
[cbr79] Multiple VULNs 8-22-25 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bmastbergen
wants to merge
6
commits into
ciqcbr7_9
Choose a base branch
from
bmastbergen_ciqcbr7_9/many-vulns-8-22-25
base: ciqcbr7_9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+66
−39
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f96e41c
net: atm: fix use after free in lec_send()
bmastbergen a57a126
HID: core: zero-initialize the report buffer
bmastbergen 49f9d93
fuse: fix pipe buffer lifetime for direct_io
bmastbergen 07d158c
ALSA: usb-audio: Fix potential out-of-bound accesses for Extigy and M…
bmastbergen 8b93ba8
ALSA: usb-audio: Fix a DMA to stack memory bug
bmastbergen c3d72d1
github actions: Switch to centos 7 container
bmastbergen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,46 +9,39 @@ jobs: | |
kernel-build-job: | ||
runs-on: | ||
labels: kernel-build | ||
container: | ||
image: centos:7 | ||
options: --cpus 8 | ||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
with: | ||
ref: "${{ github.event.pull_request.head.sha }}" | ||
fetch-depth: 0 | ||
path: kernel-src-tree | ||
|
||
- name: Install rinse | ||
run: | | ||
sudo apt-get install rinse | ||
|
||
- name: Build centos7 chroot | ||
run: | | ||
sudo rinse --distribution centos-7 \ | ||
--mirror http://dl.rockylinux.org/vault/centos/7/os/x86_64/Packages \ | ||
--arch amd64 \ | ||
--directory centos-7-chroot | ||
|
||
- name: Point yum to vault (in chroot) | ||
- name: Point yum to vault | ||
run: | | ||
sudo sed -e '/mirrorlist=.*/d' \ | ||
sed -e '/mirrorlist=.*/d' \ | ||
-e 's/#baseurl=/baseurl=/' \ | ||
-e "s/\$releasever/7.9.2009/g" \ | ||
-e "s/mirror.centos.org/dl.rockylinux.org\/vault/g" \ | ||
-i centos-7-chroot/etc/yum.repos.d/CentOS-Base.repo | ||
-i /etc/yum.repos.d/CentOS-Base.repo | ||
|
||
- name: Install tools and Libraries (in chroot) | ||
run: | | ||
sudo chroot centos-7-chroot yum groupinstall 'Development Tools' -y | ||
sudo chroot centos-7-chroot yum install bc dwarves git glibc-devel hostname kernel-devel mpfr openssl openssl-devel elfutils-libelf-devel -y | ||
yum groupinstall 'Development Tools' -y | ||
yum install bc dwarves git glibc-devel hostname kernel-devel mpfr openssl openssl-devel elfutils-libelf-devel -y | ||
|
||
- name: Build the Kernel (in chroot) | ||
- name: Checkout code | ||
run: | | ||
sudo mv kernel-src-tree centos-7-chroot | ||
sudo chroot centos-7-chroot sh -c "cd kernel-src-tree && cp configs/kernel-3.10.0-x86_64.config .config" | ||
sudo chroot centos-7-chroot sh -c "cd kernel-src-tree && make olddefconfig" | ||
sudo chroot centos-7-chroot sh -c "cd kernel-src-tree && make -j$(nproc)" | ||
git clone --branch ${{ github.head_ref }} "https://oauth2:[email protected]/ctrliq/kernel-src-tree" | ||
|
||
- name: Build the Kernel | ||
working-directory: kernel-src-tree | ||
run: | | ||
cp configs/kernel-3.10.0-x86_64.config .config | ||
make olddefconfig | ||
make -j$(nproc) | ||
|
||
- name: Check kabi | ||
working-directory: kernel-src-tree | ||
run: | | ||
sudo chroot centos-7-chroot sh -c "git clone --branch c7 --single-branch https://git.centos.org/rpms/kernel.git kernel-dist-git" | ||
sudo chroot centos-7-chroot sh -c "cd kernel-dist-git && git reset --hard imports/c7/kernel-3.10.0-1160.119.1.el7" | ||
sudo chroot centos-7-chroot sh -c "./kernel-dist-git/SOURCES/check-kabi -k ./kernel-dist-git/SOURCES/Module.kabi_x86_64 -s ./kernel-src-tree/Module.symvers" | ||
git clone --branch c7 --single-branch https://git.centos.org/rpms/kernel.git kernel-dist-git | ||
cd kernel-dist-git | ||
git reset --hard imports/c7/kernel-3.10.0-1160.119.1.el7 | ||
cd .. | ||
./kernel-dist-git/SOURCES/check-kabi -k ./kernel-dist-git/SOURCES/Module.kabi_x86_64 -s Module.symvers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -577,6 +577,7 @@ int snd_usb_create_quirk(struct snd_usb_audio *chip, | |
static int snd_usb_extigy_boot_quirk(struct usb_device *dev, struct usb_interface *intf) | ||
{ | ||
struct usb_host_config *config = dev->actconfig; | ||
struct usb_device_descriptor *new_device_descriptor = NULL; | ||
int err; | ||
|
||
if (le16_to_cpu(get_cfg_desc(config)->wTotalLength) == EXTIGY_FIRMWARE_SIZE_OLD || | ||
|
@@ -587,11 +588,20 @@ static int snd_usb_extigy_boot_quirk(struct usb_device *dev, struct usb_interfac | |
0x10, 0x43, 0x0001, 0x000a, NULL, 0); | ||
if (err < 0) | ||
dev_dbg(&dev->dev, "error sending boot message: %d\n", err); | ||
|
||
new_device_descriptor = kmalloc(sizeof(*new_device_descriptor), GFP_KERNEL); | ||
if (!new_device_descriptor) | ||
return -ENOMEM; | ||
err = usb_get_descriptor(dev, USB_DT_DEVICE, 0, | ||
&dev->descriptor, sizeof(dev->descriptor)); | ||
config = dev->actconfig; | ||
new_device_descriptor, sizeof(*new_device_descriptor)); | ||
if (err < 0) | ||
dev_dbg(&dev->dev, "error usb_get_descriptor: %d\n", err); | ||
if (new_device_descriptor->bNumConfigurations > dev->descriptor.bNumConfigurations) | ||
dev_dbg(&dev->dev, "error too large bNumConfigurations: %d\n", | ||
new_device_descriptor->bNumConfigurations); | ||
else | ||
memcpy(&dev->descriptor, new_device_descriptor, sizeof(dev->descriptor)); | ||
kfree(new_device_descriptor); | ||
err = usb_reset_configuration(dev); | ||
if (err < 0) | ||
dev_dbg(&dev->dev, "error usb_reset_configuration: %d\n", err); | ||
|
@@ -925,6 +935,7 @@ static void mbox2_setup_48_24_magic(struct usb_device *dev) | |
static int snd_usb_mbox2_boot_quirk(struct usb_device *dev) | ||
{ | ||
struct usb_host_config *config = dev->actconfig; | ||
struct usb_device_descriptor *new_device_descriptor = NULL; | ||
int err; | ||
u8 bootresponse[0x12]; | ||
int fwsize; | ||
|
@@ -959,11 +970,21 @@ static int snd_usb_mbox2_boot_quirk(struct usb_device *dev) | |
|
||
dev_dbg(&dev->dev, "device initialised!\n"); | ||
|
||
new_device_descriptor = kmalloc(sizeof(*new_device_descriptor), GFP_KERNEL); | ||
if (!new_device_descriptor) | ||
return -ENOMEM; | ||
|
||
err = usb_get_descriptor(dev, USB_DT_DEVICE, 0, | ||
&dev->descriptor, sizeof(dev->descriptor)); | ||
config = dev->actconfig; | ||
new_device_descriptor, sizeof(*new_device_descriptor)); | ||
if (err < 0) | ||
dev_dbg(&dev->dev, "error usb_get_descriptor: %d\n", err); | ||
if (new_device_descriptor->bNumConfigurations > dev->descriptor.bNumConfigurations) | ||
dev_dbg(&dev->dev, "error too large bNumConfigurations: %d\n", | ||
new_device_descriptor->bNumConfigurations); | ||
else | ||
memcpy(&dev->descriptor, new_device_descriptor, sizeof(dev->descriptor)); | ||
|
||
kfree(new_device_descriptor); | ||
|
||
err = usb_reset_configuration(dev); | ||
if (err < 0) | ||
|
@@ -1010,7 +1031,6 @@ static int snd_usb_axefx3_boot_quirk(struct usb_device *dev) | |
return 0; | ||
} | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stray newline deletion; the upstream patch doesn't have this. |
||
#define MICROBOOK_BUF_SIZE 128 | ||
|
||
static int snd_usb_motu_microbookii_communicate(struct usb_device *dev, u8 *buf, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tags are syntactically equivalent to branches, so these four lines can be simplified into:
And using
--depth 1
instead of--single-branch
produces an even smaller clone because it won't fetch any history at all. (and--depth
implies--single-branch
)