Pass 'nosort' parameter to external match function #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins can disable sorting by setting 'sort' option to 0. Ctrlp can disable sorting internally, e.g. for the mru list. Pass this information to external match function.
|
Do not merge. This break using third party matcher. ex: cspm. |
|
You are right. This was a terrible change, and I'm sorry for it. I was so careful to not break anything regarding the actual logic so I forgot that the extra parameter in the normal function call will break it all. Do you have a good idea how to achieve this? I still think it would be good to forward this information to third party matchers like mine, cspm or py-matcher. The buf and mru already have a good item order that I would like to maintain. |
|
Don't mind about my comment. This repository have few commiters. So I did let them known to not merge this change until fix. :) |
The extra argument breaks backwards compatibility with other matchers. Only pass nosort when matcher function is called with a dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented my own match function, and I need to know when I can safely sort the results and not.