fix: Allow unbounded window frames

cube-js · Dec 22, 2022 · 7d31d40 · 7d31d40
1 parent 94ddd00
commit 7d31d40
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/datafusion/core/src/physical_plan/planner.rs b/datafusion/core/src/physical_plan/planner.rs
@@ -69,6 +69,7 @@ use arrow::{compute::can_cast_types, datatypes::DataType};
 use async_trait::async_trait;
 use datafusion_common::OuterQueryCursor;
 use datafusion_expr::expr_fn::binary_expr;
+use datafusion_expr::WindowFrameBound;
 use datafusion_physical_expr::expressions::{any, OuterColumn};
 use futures::future::BoxFuture;
 use futures::{FutureExt, StreamExt, TryStreamExt};
@@ -1433,12 +1434,18 @@ pub fn create_window_expr_with_name(
                     )),
                 })
                 .collect::<Result<Vec<_>>>()?;
-            if window_frame.is_some() {
-                return Err(DataFusionError::NotImplemented(
-                    "window expression with window frame definition is not yet supported"
-                        .to_owned(),
-                ));
-            }
+            let window_frame = match window_frame {
+                Some(window_frame) => match (&window_frame.start_bound, &window_frame.end_bound) {
+                    (WindowFrameBound::Preceding(None), WindowFrameBound::CurrentRow)
+                    | (WindowFrameBound::Preceding(None), WindowFrameBound::Following(None))
+                    | (WindowFrameBound::CurrentRow, WindowFrameBound::Following(None)) => &None,
+                    (_, _) => return Err(DataFusionError::NotImplemented(
+                        "window expression with window frame definition is not yet supported"
+                            .to_owned(),
+                    )),
+                },
+                None => &None,
+            };
             windows::create_window_expr(
                 fun,
                 name,