Patch for Spade -> Filament #460
Conversation
primitives/core.sv
Outdated
| input wire logic [WIDTH-1:0] left, | ||
| output wire logic [WIDTH-1:0] out | ||
| ); | ||
| assign out = left + right; |
There was a problem hiding this comment.
What's going on here? right is not defined...
There was a problem hiding this comment.
I'm still making changes, so this is a draft PR and not ready for review. There's a lot of broken stuff right now.
There was a problem hiding this comment.
I think you might have requested a review. If that was unintentional, then tag me when ready for review.
There was a problem hiding this comment.
It might have automatically done that
| @@ -32,6 +32,16 @@ impl From<&cmdline::Opts> for Resolver { | |||
| } | |||
|
|
|||
| impl Resolver { | |||
| pub fn new(lib: Vec<PathBuf>, input: PathBuf) -> Self { | |||
There was a problem hiding this comment.
What's the use case for this method?
There was a problem hiding this comment.
I want to make a resolver without constructing an instance of the filament command line options.
primitives/core.fil
Outdated
|
|
||
| extern "core.sv" { | ||
| comp Wire[WIDTH]<'G, 'L>( |
There was a problem hiding this comment.
What would this be for? I imagine it would be for renaming ports, but it can probably be done with Filament bundles.
If you have some port p0, I guess you would want to pass it to some instantiation add_in := new Wire[W]<'G>(p0) to get a port named add_in.out that would be passed into an adder?
If you have p0, you can define a bundle bundle add_in[1]: ['G, 'G+1] W and then make the assignment add_in{0} = p0. Then you'd use add_in{0} wherever. To me, this is also more readable.
There was a problem hiding this comment.
It makes implementing Spade's Alias operation easier.
There was a problem hiding this comment.
I think we should move Spade-specific stuff to a spade.fil file instead instead of adding things to the standard library.
There was a problem hiding this comment.
Good idea, I was thinking that too
|
Ok don't actually think I need to expose |
ethanuppal
force-pushed
the
main
branch
2 times, most recently
from
5a52b97 to
538d900
Compare
NOT READY FOR REVIEW