Merge pull request #397 from TradeWing/minimongo-pull-fix

LinkMany $pull fix

lib/links/linkTypes/linkMany.js

@@ -72,8 +72,8 @@ export default class LinkMany extends Link {
 
         // update the db
         let modifier = {
-            $pull: {
-                [root]: nested.length > 0 ? {[nested.join('.')]: {$in: _ids}} : {$in: _ids},
+            $pullAll: {
+                [root]: nested.length > 0 ? { [nested.join('.')]: _ids } : _ids,
             },
         };
 

lib/links/tests/client.test.js

@@ -0,0 +1,31 @@
+import { assert } from "chai";
+
+
+describe("Links Client Tests", function() {
+
+    it("Test remove many", function() {
+        let PostCollection = new Mongo.Collection(null);
+        let CommentCollection = new Mongo.Collection(null);
+
+        PostCollection.addLinks({
+            comments: {
+                type: "many",
+                collection: CommentCollection,
+                field: "commentIds",
+                index: true,
+            }
+        });
+
+        let postId = PostCollection.insert({ text: "abc" });
+        let commentId = CommentCollection.insert({ text: "abc" });
+
+        const link = PostCollection.getLink(postId, "comments");
+        link.add(commentId);
+        assert.lengthOf(link.find().fetch(), 1);
+
+        link.remove(commentId);
+
+        assert.lengthOf(link.find().fetch(), 0);
+    });
+
+});

package.js

@@ -61,6 +61,7 @@ Package.onTest(function(api) {
 
   // LINKS
   api.addFiles("lib/links/tests/main.js", "server");
+  api.addFiles("lib/links/tests/client.test.js", "client");
 
   // EXPOSURE
   api.addFiles("lib/exposure/testing/server.js", "server");