revert redundant aria-controls and clean up linting

cultureamp · Nov 20, 2023 · 1199280 · 1199280
1 parent 241f4fb
commit 1199280
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/packages/components/src/MultiSelect/subcomponents/Popover/Popover.tsx b/packages/components/src/MultiSelect/subcomponents/Popover/Popover.tsx
@@ -1,4 +1,4 @@
-import React, { HTMLAttributes, ReactNode } from "react"
+import React, { HTMLAttributes } from "react"
 import { createPortal } from "react-dom"
 import {
   autoUpdate,

diff --git a/packages/components/src/__future__/Select/Select.spec.tsx b/packages/components/src/__future__/Select/Select.spec.tsx
@@ -349,7 +349,7 @@ describe("<Select />", () => {
       })
 
       await waitFor(() => {
-        expect(trigger).toHaveAttribute("aria-controls", expectedPopoverId)
+        expect(trigger).toHaveAttribute("aria-controls")
       })
     })
 
@@ -399,7 +399,7 @@ describe("<Select />", () => {
           "#id--select--popover"
         )
 
-        expect(popoverAsDescendant).toHaveAttribute("role", "dialog")
+        expect(popoverAsDescendant).toBeInTheDocument()
       })
     })
   })

diff --git a/packages/components/src/__future__/Select/Select.tsx b/packages/components/src/__future__/Select/Select.tsx
@@ -139,7 +139,6 @@ export const Select = <Option extends SelectOption = SelectOption>({
     isDisabled: triggerProps.isDisabled,
     isReversed,
     ref: refs.setReference,
-    "aria-controls": popoverId,
   }
 
   return (