Skip to content

Commit

Permalink
Increase opacity on placeholder in Select (#4369)
Browse files Browse the repository at this point in the history
  • Loading branch information
harrisrachel authored Nov 27, 2023
1 parent 5baff64 commit 379d301
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 19 deletions.
5 changes: 5 additions & 0 deletions .changeset/honest-weeks-sniff.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@kaizen/components": patch
---

Change placeholder opacity on Select
2 changes: 1 addition & 1 deletion packages/components/src/Select/Select.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

// Should match the values for the Input component
$input-height: 48px;
$input-placeholder-opacity: 0.5;
$input-placeholder-opacity: 0.7;

$focus-border-color: $color-blue-500;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ export default {
a11y: {
config: {
rules: [
{
// Placeholders do not pass color contrast
id: "color-contrast",
enabled: false,
},
{
// React-select's list structure missing when there are no options (third-party a11y issue)
id: "aria-required-children",
Expand Down
13 changes: 0 additions & 13 deletions packages/components/src/Select/_docs/Select.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,6 @@ const meta = {
options: OPTIONS,
label: "Select",
},
parameters: {
a11y: {
config: {
rules: [
{
// Placeholders do not pass color contrast
id: "color-contrast",
enabled: false,
},
],
},
},
},
} satisfies Meta<typeof Select>

export default meta
Expand Down

0 comments on commit 379d301

Please sign in to comment.