Kds 1754 migrate toggle switch field guidance block scene to kaio #4062
Conversation
|
JakePitman
force-pushed
the
KDS-1754-migrate-toggle-switch-field-guidance-block-scene-to-kaio
branch
from
50b8fe0 to
9543580
Compare
| .cancel { | ||
| @include button-reset; | ||
|
|
||
| composes: interactiveIconWrapper from "~@kaizen/component-library/components/Icon/Icon.module.scss"; |
There was a problem hiding this comment.
We want to remove these cause they aren't the best supported feature in our bundling tools, and generally confusing.
Winter actually migrated these styles over to components/src/Notification/utils/_styles.scss
Maybe best to move the styles from Notification to components/styles so both components can extend them. I think you want to extend %ca-notification_cancel here.
There was a problem hiding this comment.
You want all styles from components/src/Notification/utils/_styles.scss moved over & shared? Or just %ca-notification__cancel?
There was a problem hiding this comment.
Hm, now that I take a second look, maybe they belong with Icon...? Icon/styles/_styles.scss, thoughts?
There was a problem hiding this comment.
Just realized slack isn't a great place for keeping info so re-sharing here to capture as food for thought when we loop back here in a health week:
Without having dug too deep into it, just looking at the functionality of the shared styles, it feels like we should try to use a component like IconButton instead of extending (or composing) a class. I'm assuming the older pattern of Guidance block and Menu may be a factor as to why this was done in the pas
packages/components/src/ToggleSwitchField/ToggleSwitchField.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/ToggleSwitchField/Primitives/ToggleSwitch/ToggleSwitch.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Scene/_docs/IllustrationScene.stories.tsx
Outdated
Show resolved
Hide resolved
|
You'll need to follow the |
packages/components/src/GuidanceBlock/_docs/GuidanceBlock.stories.tsx
Outdated
Show resolved
Hide resolved
| automationId?: string | ||
| } | ||
|
|
||
| export const FieldGroup = ({ |
There was a problem hiding this comment.
Just flagging that this has already been migrated
| automationId?: string | ||
| } | ||
|
|
||
| export const Label = ({ |
There was a problem hiding this comment.
Just flagging that this has already been migrated
…e-block-scene-to-kaio
…e-block-scene-to-kaio
|
Broke this into multiple PRs, closing. |
gyfchong
deleted the
KDS-1754-migrate-toggle-switch-field-guidance-block-scene-to-kaio
branch
Why
Part of migrating legacy components to KAIO
What
Migrates the following legacy packages to packages/compoents: