Kds 1611 fix border config #4256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 30a1ac1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JakePitman
force-pushed
the
KDS-1611-fix-border-config
branch
from
a6fbd6d to
b0942eb
Compare
…izen-design-system into KDS-1611-fix-border-config
…izen-design-system into KDS-1611-fix-border-config
gyfchong
reviewed
Nov 5, 2023
Comment on lines
+1
to
+7
| *, | ||
| ::before, | ||
| ::after { | ||
| border-width: 0; | ||
| border-style: solid; | ||
| border-color: var(--border-solid-border-color, "currentColor"); | ||
| } |
…izen-design-system into KDS-1611-fix-border-config
gyfchong
reviewed
Nov 6, 2023
gyfchong
reviewed
Nov 6, 2023
…izen-design-system into KDS-1611-fix-border-config
mcwinter07
reviewed
Nov 8, 2023
mcwinter07
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, adding a border with our TW preset involves writing six utility classes, as seen in this example. This is a source of constant frustration to our consumers, who report that they keep forgetting how to add a border, or end up saving it as a code-snippet. It also just adds bloat to consumer code, making components less readable.
This solution reduces the utility classes needed to create a border from six, to one, as seen in this example.
What
@kaizen/tailwindpackage with some sensibleDEFAULTvalues for border styles.@kaizen/resetpackage, that exports a css reset that enables more efficient TW border utilities.@kaizen/resetto a project in the app starter