Kds 1953 port button fix from kaizen legacy #4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b8c60a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gyfchong
reviewed
Nov 20, 2023
.changeset/popular-gifts-sing.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@kaizen/components": minor | |||
There was a problem hiding this comment.
Should this be a patch as it seems to fix an issue?
Suggested change
| "@kaizen/components": minor | |
| "@kaizen/components": patch |
JakePitman
force-pushed
the
KDS-1953-port-button-fix-from-kaizen-legacy
branch
from
2e73f34 to
1d84f2a
Compare
mcwinter07
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Nice stuff. The stories a good example for our test cases, but I'm wondering if we add it to our docs page to show a basic pattern in action? Potentially we could add it as a canvas below the story that shows its multiple states. Either than or just add a button to the original story to end the working status
mcwinter07
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There was an issue where screen readers would announce the button's contents on page load.
What
Sets
aria-liveattribute topoliteonly when aworkingLabelis present.Adds tests ✨
Adds a story to demonstrate button transitioning from a 'ready' state, to 'working', to 'completed'. This story also demonstrates how the screen reader behaves when the button transitions in and out of the 'working' state.