Fix: future Select and FilterSelect page jump on focus issue #5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 42ceda4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcwinter07
force-pushed
the
KZN-2719/future-and-filter-select-page-jump-on-focus-fix
branch
from
7d6e76e to
6deb104
Compare
mcwinter07
force-pushed
the
KZN-2719/future-and-filter-select-page-jump-on-focus-fix
branch
from
40dc332 to
5a21407
Compare
mcwinter07
changed the title
HeartSquared
reviewed
Oct 4, 2024
packages/components/src/Filter/FilterSelect/FilterSelect.spec.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Filter/FilterSelect/FilterSelect.spec.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Filter/FilterSelect/FilterSelect.spec.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/Filter/FilterSelect/_docs/FilterSelect.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/__future__/Select/_docs/Select.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/__future__/Select/_docs/Select.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/__future__/Select/subcomponents/ListBox/ListBox.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/__future__/Select/subcomponents/ListBox/ListBox.tsx
Outdated
Show resolved
Hide resolved
dougmacknz
reviewed
Oct 8, 2024
packages/components/src/__future__/Select/subcomponents/ListBox/ListBox.tsx
Outdated
Show resolved
Hide resolved
…x/ListBox.tsx Co-authored-by: Doug MacKenzie <[email protected]>
dougmacknz
approved these changes
Oct 8, 2024
HeartSquared
approved these changes
Oct 8, 2024
mcwinter07
deleted the
KZN-2719/future-and-filter-select-page-jump-on-focus-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
windowanddocumentobjects are available to our components