Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): enable consistent-type-imports #5403

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

HeartSquared
Copy link
Contributor

What

Update linting:

  • Enable @typescript-eslint/consistent-type-imports
  • Sort imports alphabetically per import

@HeartSquared HeartSquared requested a review from a team as a code owner December 17, 2024 05:46
Copy link

changeset-bot bot commented Dec 17, 2024

🦋 Changeset detected

Latest commit: 1d56682

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 17, 2024

✨ Here is your branch preview! ✨

Last updated for commit 1d56682: style: fix linting errors

@HeartSquared HeartSquared force-pushed the heartsquared/eslint-ts-imports branch from be750dc to 1d56682 Compare December 18, 2024 03:46
Copy link
Contributor

@mcwinter07 mcwinter07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated eslint config looks good. I don't think I need to check all 600+ imports but the first block I looked at seem super fine so will give the ✅

@HeartSquared HeartSquared merged commit d0aa7d7 into main Dec 18, 2024
19 checks passed
@HeartSquared HeartSquared deleted the heartsquared/eslint-ts-imports branch December 18, 2024 03:58
Zystix pushed a commit that referenced this pull request Dec 18, 2024
* chore(eslint): enable consistent-type-imports

* style: fix linting errors
Zystix pushed a commit that referenced this pull request Dec 18, 2024
* chore(eslint): enable consistent-type-imports

* style: fix linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants