Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update translations #5432

Closed
wants to merge 2 commits into from
Closed

Conversation

ca-translation-bot
Copy link
Collaborator

This Pull Request was opened by the translation-bot.

Q: This is all Greek to me. How do I review this Pull Request?
A: Well it's not all Greek. Culture Amp supports many other languages. We don't expect you to understand all the text. You can review this PR by double checking for any syntax errors. For example—a translated HTML tag or variable name, or html tags that have been reversed.

Q: It looks like there's English text inside a file for a different language. Is that OK?
A: Yes. When a new string is added it will show up as English until that string is translated. After it has been translated the next PR will include the translated text.

Q: This PR has conflicts. What do I do?
A: The easiest way to fix up conflicts is to close this Pull Request and delete the branch. The translation bot—that's me—will create a new pull request with a clean branch in the next run.

If you can, try using git annotate to figure out how the conflict came about, or let #team_connect know. A conflict might mean someone has made a change to a translation in a way that won't be preserved.

Q: There's something wrong with this Pull Request. Who should I tell?
A: Please reach out to #team_connect

@ca-translation-bot ca-translation-bot requested a review from a team as a code owner December 24, 2024 18:04
Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: 536155c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 24, 2024

✨ Here is your branch preview! ✨

Last updated for commit 536155c: Merge branch 'main' into translation-bot-updates

@@ -35,7 +35,7 @@
},
"filterBar.addFiltersMenu.buttonLabel" : {
"description" : "Menu button label to show additional available filter options",
"message" : "Add filters"
"message" : "Add Filters"
Copy link
Contributor

@mcwinter07 mcwinter07 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, this is actually counter to the update we made. We might have to go into smartling and reject this translation if we can

@mcwinter07
Copy link
Contributor

Rejecting this because it is counter to our guidelines on english strings - see thread that addressed this initially

@mcwinter07 mcwinter07 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants