Required weekday fix #122
Open
Required weekday fix #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, changes to artifact_paths for an already created resource
with state would result in the 2nd element of diff.GetChange("settings")
to contain only nils. This is possibly a regression of
hashicorp/terraform#17931
This allows the default passthrough importer to work.
Because both build_config_id and the resprective resource IDs are needed, the importer for those resourrces take both as a space-separated string in the last argument of `terraform import`. Read was also updated to remove state for missing artifact dependencies.
…buildconfig use d.haschange switch to use forked go-teamcity, add rename support for project and buildconfig
switch to use forked go-teamcity, add rename support for project & buildconfig
TEST=manual pushed this branch rebuilt terraform bin with it tried to use the mode field
Previously VCS entries would only be added but never removed. It now follows similar behaviour to how steps are updated.
Return error if there are duplicate build step names
Return error if there are duplicate build step names
Also added validation of the cron expression. This validation occurs during the terraform apply stage.
The goal of this change is to have changes in VCS checkout rules be detected as a change in the teamcity_build_config resource. This will detach the VCS root and re-attach it with the new checkout rules. Prior to this change, updates to checkout rules were not detected, and the only way to apply them was to manually detach the VCS first.
tested locally on updating the cron_schedule value, trigger_schedule resource was deleted and recreated instead of showing an error not able to update
support update to cron_schedule in teamcity_build_trigger_schedule
…y schedule (#14) For teamcity_build_trigger_schedule resources, if the schedule is weekly, the weekday field must be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removing unused variable