Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: teamcity_project_feature_versioned_settings #78

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Apr 22, 2020

This introduces a new resource for managing the Versioned Settings Feature for a Project

Whilst implementing this I realised I missed support for configuring "credentialsStorageType" which allows using the Secure Tokens rather than scrambling values - which is tracked in cvbarros/go-teamcity#76 - as such that'll need to be merged for this to work

@tombuildsstuff tombuildsstuff marked this pull request as draft April 23, 2020 11:44
@cvbarros cvbarros added this to the 1.1 milestone Apr 24, 2020
@tombuildsstuff
Copy link
Contributor Author

Dependent on cvbarros/go-teamcity#85

@tombuildsstuff
Copy link
Contributor Author

With the dependencies available the tests pass:

$ TEAMCITY_ADDR=http://localhost:8112 TEAMCITY_USER=admin TEAMCITY_PASSWORD=admin TF_ACC=1 go test -v ./teamcity/ -run=TestAccTeamcityProjectVersionedSe
=== RUN   TestAccTeamcityProjectVersionedSettings_Basic
--- PASS: TestAccTeamcityProjectVersionedSettings_Basic (0.87s)
=== RUN   TestAccTeamcityProjectVersionedSettings_Update
--- PASS: TestAccTeamcityProjectVersionedSettings_Update (3.40s)
=== RUN   TestAccTeamcityProjectVersionedSettings_ContextParameters
--- PASS: TestAccTeamcityProjectVersionedSettings_ContextParameters (2.90s)
=== RUN   TestAccTeamcityProjectVersionedSettings_CredentialsStorageTypeSettings
--- PASS: TestAccTeamcityProjectVersionedSettings_CredentialsStorageTypeSettings (2.93s)
PASS
ok  	github.com/cvbarros/terraform-provider-teamcity/teamcity	10.128s

@cvbarros cvbarros modified the milestones: 1.1, 1.2 Jun 11, 2020
@cvbarros
Copy link
Owner

👋 @tombuildsstuff mind rebasing on master for the client upgrade? Then this will be gtg, thanks!

@fatmcgav fatmcgav mentioned this pull request Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants