Merge pull request #616 from NathanEmb/basketball-typehints

Basketball - Add player and team typehints
cwendt94 · Dec 9, 2024 · 47a31fd · 47a31fd
2 parents 216fef4 + 25bac50
commit 47a31fd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/espn_api/basketball/league.py b/espn_api/basketball/league.py
@@ -11,6 +11,7 @@
 from .constant import POSITION_MAP, ACTIVITY_MAP, TRANSACTION_TYPES
 
 class League(BaseLeague):
+    teams: List[Team]
     '''Creates a League instance for Public/Private ESPN league'''
     def __init__(self, league_id: int, year: int, espn_s2=None, swid=None, fetch_league=True, debug=False):
         super().__init__(league_id=league_id, year=year, sport='nba', espn_s2=espn_s2, swid=swid, debug=debug)

diff --git a/espn_api/basketball/team.py b/espn_api/basketball/team.py
@@ -1,3 +1,5 @@
+from typing import List
+
 from .player import Player
 from .matchup import Matchup
 from .constant import STATS_MAP
@@ -23,7 +25,7 @@ def __init__(self, data, roster, schedule, year, **kwargs):
         self.stats = None
         self.standing = data['playoffSeed']
         self.final_standing = data['rankCalculatedFinal']
-        self.roster = []
+        self.roster: List[Player] = []
         self.schedule = []
 
         if 'valuesByStat' in data: