Update player.py

Shift position & lineupSlot lookups by one to account for incongruency with the position keys in the eligibleSlots field.
cwendt94 · Nov 21, 2023 · 7f52448 · 7f52448
1 parent 3922a29
commit 7f52448
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/espn_api/hockey/player.py b/espn_api/hockey/player.py
@@ -7,8 +7,12 @@ class Player(object):
     def __init__(self, data):
         self.name = json_parsing(data, 'fullName')
         self.playerId = json_parsing(data, 'id')
-        self.position = POSITION_MAP.get(json_parsing(data, 'defaultPositionId'), '')
-        self.lineupSlot = POSITION_MAP.get(data.get('lineupSlotId'), '')
+        self.position = POSITION_MAP.get(json_parsing(data, 'defaultPositionId') - 1
+                                         if json_parsing(data, 'defaultPositionId') and json_parsing(data, 'defaultPositionId') <= 3 
+                                         else json_parsing(data, 'defaultPositionId'), '')
+        self.lineupSlot = POSITION_MAP.get(data.get('lineupSlotId') - 1
+                                           if data.get('lineupSlotId') and data.get('lineupSlotId') <= 3 
+                                           else data.get('lineupSlotId'), '')
         self.eligibleSlots = [POSITION_MAP.get(pos, '') for pos in json_parsing(data, 'eligibleSlots')]
         self.acquisitionType = json_parsing(data, 'acquisitionType')
         self.proTeam = PRO_TEAM_MAP.get(json_parsing(data, 'proTeamId'), 'Unknown Team')