feat: Add active status to Player
#502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the embedded stats objects to decipher whether a player was active in a historical week. * `active`: the player had a game and participated in it * `inactive`: the player had a game but did not participate in it (due to injury or suspension) * `bye`: the player did not have a game that week
I'm just an idiot don't mind me
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 80.53% 80.57% +0.04%
==========================================
Files 59 59
Lines 2106 2111 +5
==========================================
+ Hits 1696 1701 +5
Misses 410 410 ☔ View full report in Codecov by Sentry. |
|
@cwendt94 Any update on this PR? |
|
Thanks for the bump @DesiPilla and figuring out a work around from ESPNs data. Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR can finally resolve a long-standing issue... historical injury status! For a while now, an issue (#327, #401) we've had is that ESPN only return's a player's current health status, even when querying a previous week or year. I think I have a way to get around this and assume a player's health status from previous weeks.
This uses the embedded stats objects to decipher whether a player was active in a historical week.
active: the player had a game and participated in itinactive: the player had a game but did not participate in it (due to injury or suspension)bye: the player did not have a game that weekTesting and research can be viewed here.