Hockey position update #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Align the position IDs with the values inside of the eligible position values
Offset lookups for the forward positions to the new POSITION_MAP assignments for the position and lineupSlot since they don't align with the number values in the eligibleSlots fields.
|
Refactoring to handle NoneType failure... |
Check for None type on position & lineupSlot parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the hockey\constant.py file to align with the positions in the eligibleSlots values. Modified the position and lineupSlots assignments in hockey\player.py to reflect the proper positions in the updated constant.py file.