-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add method to calculate historical standings for any week #515
Conversation
Subject to the league's specific tiebreaker rules
I'm used to always having `pandas` and `numpy` available, made that change now.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #515 +/- ##
==========================================
+ Coverage 80.60% 81.03% +0.42%
==========================================
Files 59 60 +1
Lines 2114 2209 +95
==========================================
+ Hits 1704 1790 +86
- Misses 410 419 +9 ☔ View full report in Codecov by Sentry. |
@cwendt94 looks like we don't have any test leagues that use |
Now explicitly tests for the exact standings of the test league
@DesiPilla could you move all of the helper functions in its own file |
@cwendt94 I agree that's the cleaner way to do it. I moved everything over now. I'm making some test cases for the sorting criteria that don't get run by default so that we have better code coverage. |
Thank you, this is looking good! |
I added some more comprehensive testing, and along the way uncovered some bugs (this is why we write test cases!)
@cwendt94 alright the coverage should be good now. |
@DesiPilla great work and thanks for adding the coverage! |
This PR is to replace another attempt.
The tiebreaking process is quite complicated, but this follows all tiebreaking levels, subject to a league's specific tiebreaker rules.