fix: Add caching to speed up BoxScore loading
#562
Conversation
the `.box_score()` method can take ~1.5s on average to load, making it very slow if your code iterates over this many times. Adding this cache makes it easier to work with and orders of magnitude faster.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 84.32% 84.34% +0.01%
==========================================
Files 60 60
Lines 2227 2229 +2
==========================================
+ Hits 1878 1880 +2
Misses 349 349 ☔ View full report in Codecov by Sentry. |
|
@DesiPilla dumb question , but wouldn't this mean that it doesn't fetch the latest score (and wouldn't have live updates?). Ie if the score has changed since you last called the function you would get a stale result? |
|
@mkirby528 This is true. I guess, as a default, this function has more use-cases for live score changes. My use case in particular is not, and I can manually overload the function to cache. |
|
Yeah totally get where you are coming from, but was wanting to make sure this doesn't break my usecase where im using it to display the live scores of all my games |
A very small PR to make the repo a bit faster in one use case. The
.box_score()method can take ~1.5s on average to load, making it very slow if your code iterates over this many times. Adding this cache makes it easier to work with and orders of magnitude faster.