Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return empty standings prior to Week 1 #565

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: Return empty standings prior to Week 1 #565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions espn_api/football/league.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@
Returns:
List[Dict]: Sorted standings list
"""
# Return empty standings if no matchup periods have completed yet
if self.currentMatchupPeriod <= 1:
return self.standings()

Check warning on line 134 in espn_api/football/league.py

View check run for this annotation

Codecov / codecov/patch

espn_api/football/league.py#L134 

Added line #L134 was not covered by tests

# Get standings data for each team up to the given week
list_of_team_data = []
for team in self.teams:
Expand Down
Loading