-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2018 Fantasy Football API Update #615
Merged
Merged
Changes from 12 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4be0e23
handle data is in list and handle appropriately
59f57ef
added function check_league_endpoint to validate if either endpoint w…
6de93f4
added check & handle for data in list to fetch_draft function
cbbe230
updated espn_requests to check & handle 2018 JSON format
f31f0b8
moved JSON checking from base_league to espn_requests for 2018 data
a760004
Merge branch 'cwendt94:master' into 2018-api-update
Robert-litts dd582c3
moved JSON response list check to league_get
07acba1
added incorrectly removed returns & finalized logic in league_get
ceb79c4
Merge branch 'cwendt94:master' into 2018-api-update
Robert-litts 0f6692c
refactored check_league_endpoint to handle 401/404 errors, using chec…
a5ccc56
moved check_league_endpoint into existing checkRequestStatus function
e63cfe0
added params/headers into checkRequestStatus
ef92626
moved checkRequestStatus into class EspnFantasyRequests
2e6d5eb
Merge branch 'cwendt94:master' into 2018-api-update
Robert-litts d64b1cd
modified test_private_league to verify league switched to fallback URL
1376c78
modified test_private_league to verify league switched to fallback UR…
a717848
fixed typo in LEAGUE_ENDPOINT URL in assert equal test
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this function a little simpler, I think moving this inside the request class so then you won't have to pass all these fields to it. You then can access all of them through
this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I was actually considering that last night, but wasn't sure if you had a reason it was defined outside the class. Moving it inside would definitely simplify access to those params for sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah no issues moving it in!