Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Proxy support #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding Proxy support #181

wants to merge 1 commit into from

Conversation

assafjh
Copy link

@assafjh assafjh commented Nov 7, 2023

Desired Outcome

Conjur API uses the net/http module which supports proxy.
When creating a new HTTPS client we ignore proxy configuration at http.Transport

Implemented Changes

http.ProxyFromEnvironment was added to http.Transport - we now support http_proxy, https_proxy, no_proxy from env params.

@assafjh assafjh changed the title Adding API support Adding Proxy support Nov 7, 2023
@szh szh added the contributor label Nov 7, 2023
@szh szh requested a review from a team November 7, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assafjh @szh