-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set/reset the world modified flag and 'DEF' fields #6686
Open
MNikoliCC
wants to merge
12
commits into
cyberbotics:master
Choose a base branch
from
MNikoliCC:fix-def-save-scene-tree
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eir initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the'DEF' fields.
omichel
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source code tests are failing.
Can you fix them?
MNikoliCC
changed the title
Fix issue #5225
Set/reset the world modified flag and 'DEF' fields
Oct 24, 2024
lukicdarkoo
reviewed
Oct 25, 2024
worldCheckTimer->start(500); | ||
} | ||
|
||
void WbNodeEditor::tryConnectToWorld() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot have a timer here, we need a cleaner solution
…ew Signal When The 'world' Instance Is Created
lukicdarkoo
added
bug
Something isn't working
test distribution
Start the distribution test
test suite
Start the test suite
test webots build
Start the build tests
test worlds
Start the worlds test
labels
Nov 11, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
test distribution
Start the distribution test
test suite
Start the test suite
test webots build
Start the build tests
test worlds
Start the worlds test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All modified 'DEF' fields are reset to their initial values when the simulation is reset. The world modified flag is only set when the simulation time is 0 and there is a change between any of the initial and modified values in the 'DEF' fields.
Related Issues
Fixes #5225
Tasks