Reduce memtory usage #83
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring up to date
tweaks to reduce memory use, still WIP
| @@ -12,13 +12,12 @@ batch_read = function( | |||
| cols_to_keep = c( | |||
| "name", # not used currently but could be handy | |||
| "distances", | |||
| "gradient_smooth", | |||
There was a problem hiding this comment.
We ultimately need that column. Fine if it works, surprised if it does after this change though.
| res = readr::read_csv(file, show_col_types = FALSE) | ||
| n_char = nchar(res$json) | ||
|
|
||
| res = data.table::fread(file, select = "json") |
There was a problem hiding this comment.
I agree with this, readr, which uses vroom, seems to be unreliable.
| @@ -90,17 +88,18 @@ json2sf_cs = function( | |||
| message(results_error$Freq[msgs],'x messages: "',results_error$results_error[msgs],'"\n') | |||
| } | |||
| } | |||
|
|
|||
| results = RcppSimdJson::fparse(results_raw, query = "/marker", query_error_ok = TRUE, always_list = TRUE) | |||
There was a problem hiding this comment.
Is there a way to reduce what is read-in here with a different query?
| @@ -147,6 +146,7 @@ cleanup_results <- function(x, cols_to_keep){ | |||
| x = add_columns(x) | |||
| x = sf::st_as_sf(x) | |||
| x$SPECIALIDFORINTERNAL2 <- NULL | |||
| cols = cols_to_keep %in% names(x) | |||
| x[cols_to_keep] | |||
| cols_to_keep3 = unique(c(cols_to_keep,"gradient_segment","elevation_change","gradient_smooth")) | |||
There was a problem hiding this comment.
What if any of these are not needed? For NPT gradient_smooth is the only one we need.
| @@ -44,10 +44,10 @@ route_rolling_average = function(x, n = 3) { | |||
|
|
|||
|
|
|||
| get_values = function(v, fun) { | |||
| sapply(v, function(x) fun(as.numeric(x))) | |||
| vapply(v, function(x) fun(as.numeric(x)), 1) | |||
There was a problem hiding this comment.
Same outcome, what's the advantage?
| } | ||
|
|
||
| extract_values = function(x) stringr::str_split(x, pattern = ",") | ||
| extract_values = function(x) stringi::stri_split_fixed(x, pattern = ",") |
There was a problem hiding this comment.
Sounds reasonable, what's the thinking behind this.
|
Can you try to make actions happy also Malcolm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP so just a place holder, but a few tweaks to reduce memory usage