-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive template auth #613
Merged
petar-cvit
merged 10 commits into
cyclops-ui:main
from
Abiji-2020:interactive-template-auth
Nov 7, 2024
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d475609
feature: template_auth_rules - created a interactive CLI when there a…
Abiji-2020 932950b
fix: had a extra line which prints the values of the variables used f…
Abiji-2020 d3a6863
Update cyctl/internal/create/template_auth_rules.go
Abiji-2020 7f7040c
Update cyctl/internal/create/template_auth_rules.go
Abiji-2020 1bd1bb4
Update cyctl/internal/create/template_auth_rules.go
Abiji-2020 ee3628f
Update cyctl/internal/create/template_auth_rules.go
Abiji-2020 965e668
✍️ formated the code
Abiji-2020 e030302
Merge branch 'cyclops-ui:main' into interactive-template-auth
Abiji-2020 c377749
fix: moved the variables to the createTemplateAuthRule function for l…
Abiji-2020 12344f8
fix typo
petar-cvit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these four from here.
username
andpassword
are here because those are used to bind flag valuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this I have a doubt here that we are taking the individuals and should we need to add the values the same as username secret name: username secret key , and password secret name: password secret key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abiji-2020 I would just move these variables to
createTemplateAuthRule
function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petar-cvit could you check it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petar-cvit Modified it.