-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs: Add best practices for element interaction patterns and command chaining #6242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for cypress-docs pending review.Visit the deploys page to approve it
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment about chaining, although I don't have the background to comment on your complete documentation section. The chaining part would need to be revised in order to be correct.
Are you intending to improve this PR or have you dropped it now? |
Hello @MikeMcC399 , |
As I wrote previously, I can't judge the rest of your submission. You will need to wait for other reviews in order to know whether it is accepted or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the comment about chaining, your PR fails to build, so you would need to correct both issues.
Check the instructions in https://github.com/cypress-io/cypress-documentation/blob/main/README.md about how to build and view your changes locally before pushing them to GitHub to avoid also build failures in CircleCI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have addressed my previous comments. Now your article section needs to be reviewed by a subject matter expert, so hopefully the Cypress.io team will respond to you.
closes #6189