Skip to content

Conversation

ziad404
Copy link

@ziad404 ziad404 commented Aug 10, 2025

closes #6189

Copy link

netlify bot commented Aug 10, 2025

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 829e5ff

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@ziad404 ziad404 changed the title Add best practices for element interaction patterns and command chaining docs:Add best practices for element interaction patterns and command chaining Aug 10, 2025
@ziad404 ziad404 changed the title docs:Add best practices for element interaction patterns and command chaining docs: Add best practices for element interaction patterns and command chaining Aug 10, 2025
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziad404

I added a comment about chaining, although I don't have the background to comment on your complete documentation section. The chaining part would need to be revised in order to be correct.

@MikeMcC399
Copy link
Contributor

@ziad404

Are you intending to improve this PR or have you dropped it now?

@ziad404
Copy link
Author

ziad404 commented Aug 19, 2025

Hello @MikeMcC399 ,
Just want to make sure that I got your comment , the only section which should be edited is the chaining part , right ?

@MikeMcC399
Copy link
Contributor

@ziad404

Just want to make sure that I got your comment , the only section which should be edited is the chaining part , right ?

As I wrote previously, I can't judge the rest of your submission. You will need to wait for other reviews in order to know whether it is accepted or not.

@ziad404 ziad404 requested a review from MikeMcC399 August 25, 2025 08:17
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the comment about chaining, your PR fails to build, so you would need to correct both issues.

@MikeMcC399
Copy link
Contributor

@ziad404

Check the instructions in https://github.com/cypress-io/cypress-documentation/blob/main/README.md about how to build and view your changes locally before pushing them to GitHub to avoid also build failures in CircleCI.

@ziad404 ziad404 requested a review from MikeMcC399 August 25, 2025 10:50
Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ziad404

You have addressed my previous comments. Now your article section needs to be reviewed by a subject matter expert, so hopefully the Cypress.io team will respond to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Best practice - then() usage vs chained commands
4 participants