Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix snyk scan to ignore the nx cloud build files #31025

Merged
merged 3 commits into from
Feb 11, 2025
Merged

chore: fix snyk scan to ignore the nx cloud build files #31025

merged 3 commits into from
Feb 11, 2025

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

Fix snyk scan to ignore the nx cloud build files

Steps to test

How has the user experience changed?

PR Tasks

@jennifer-shehane jennifer-shehane self-requested a review February 5, 2025 17:03
@cypress Cypress
Copy link

cypress bot commented Feb 5, 2025 •
edited
Loading

cypress    Run #60245

Run Properties:  status check passed Passed #60245  •  git commit c62114142f: bump elliptic
Project cypress
Branch Review ryanthemanuel-patch-2
Run status status check passed Passed #60245
Run duration 17m 31s
Commit git commit c62114142f: bump elliptic
Committer Ryan Manuel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 9
Tests that did not run due to a developer annotating a test with .skip  Pending 1099
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26542
View all changes introduced in this branch ↗︎
UI Coverage  45.56%
  Untested elements 191  
  Tested elements 164  
Accessibility  92.54%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 888  

jennifer-shehane
jennifer-shehane approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm this removes the error that was printing before trying to scan the .nx cache

@ryanthemanuel ryanthemanuel merged commit 1042f4a into develop Feb 11, 2025
84 of 88 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanthemanuel-patch-2 branch February 11, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacieprins cacieprins cacieprins approved these changes

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

@mschile mschile mschile approved these changes

Assignees

@ryanthemanuel ryanthemanuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanthemanuel @cacieprins @jennifer-shehane @mschile