-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add logic to dynamically load studio functionality #31033
Open
ryanthemanuel
wants to merge
10
commits into
develop
Choose a base branch
from
ryanm/chore/add_internal_studio
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
Project |
cypress
|
Branch Review |
ryanm/chore/add_internal_studio
|
Run status |
|
Run duration | 17m 12s |
Commit |
|
Committer | Ryan Manuel |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
1
|
|
1
|
|
28
|
|
0
|
|
761
|
View all changes introduced in this branch ↗︎ |
UI Coverage
63.64%
|
|
---|---|
|
30
|
|
56
|
Accessibility
96.21%
|
|
---|---|
|
0 critical
4 serious
1 moderate
0 minor
|
|
194
|
Tests for review
cypress\e2e\runner\sessions.ui.cy.ts • 1 failed test • app-e2e
Test | Artifacts | |
---|---|---|
runner/cypress sessions.ui.spec > does not save session when validation fails |
Test Replay
Screenshots
|
cypress\e2e\specs_list_actual_git_repo.cy.ts • 1 flaky test • app-e2e
Test | Artifacts | |
---|---|---|
Spec List - Last updated with git info > shows correct git icons |
Test Replay
Screenshots
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR lays the groundwork for being able to dynamically load studio functionality. There are no current functional changes with this PR (which is why it's a chore), but this work will eventually drive updates to the Studio UI, bug fixes for Studio, and AI recommendations for how to modify specs.
This PR:
CYPRESS_ENABLE_CLOUD_STUDIO
andCYPRESS_LOCAL_APP_STUDIO_PATH
) as development placeholders to enable logic that pulls a bundle from the cloud that contains both frontend and backend code that will eventually drive studio functionalitySteps to test
The best way to test this is to:
cypress-services
repoyarn
yarn watch
inpackages/app-studio
CYPRESS_LOCAL_APP_STUDIO_PATH
to the path to thecypress-services/packages/app-studio/dist/development
directorycypress
repoyarn
yarn cypress:open
Then you can open a specific project and should be able to see the console log of
Studio loaded
as an indication that everything is synced up properly.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?