internal: allow studio panel to be draggable #31747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mabel/issue-31275-dragging-studio-panel
|
| Run status |
|
| Run duration | 11m 11s |
| Commit |
|
| Committer | Mabel Amaya |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
689
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
37.62%
|
|
|---|---|
|
Untested elements
|
131
|
|
Tested elements
|
79
|
Accessibility
92.36%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
1 moderate
1 minor
|
|
Failed elements
|
429
|
mabela416
requested review from
jennifer-shehane,
mschile,
ryanthemanuel,
astone123 and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a draggable studio panel with a fixed minimum width of 340px. The changes include updating constants to include a minimum width for the studio panel, extending the panel resizing logic and UI to support an additional panel, and adding tests for the new panel functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/app/src/runner/runner-constants.ts | Adds a new constant for the studio panel's minimum width |
| packages/app/src/runner/SpecRunnerOpenMode.vue | Introduces new props for studio panel dimensions and updates panel visibility logic |
| packages/app/src/runner/ResizablePanels.vue | Implements resizing functionality and event handling for the studio panel (panel4) |
| packages/app/src/runner/ResizablePanels.cy.tsx | Adds tests verifying panel resizing behavior including the studio panel |
Comments suppressed due to low confidence (1)
packages/app/src/runner/ResizablePanels.cy.tsx:8
- The tests reference runnerConstants.defaultStudioWidth, but the constants file only defines absoluteStudioMinimum. Ensure that a defaultStudioWidth property is defined in runnerConstants or update references accordingly.
const defaultPanel4Width = runnerConstants.defaultStudioWidth
…ragging-studio-panel' into mabel/issue-31275-dragging-studio-panel
astone123
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Studio: Studio panel should allow dragging to wider/smaller widths #31275
Additional details
Steps to test
Dragging
Uploading Screen Recording 2025-05-20 at 2.26.35 PM.mov…
Screenshotting
Screen.Recording.2025-05-20.at.1.54.46.PM.mov
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?