chore: add ui states tests #31768
Merged
chore: add ui states tests #31768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
alejandro/chore/add-ui-states-tests
|
| Run status |
|
| Run duration | 16m 33s |
| Commit |
|
| Committer | Alejandro Estrada |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
133
|
Skipped
|
0
|
Passing
|
5559
|
| View all changes introduced in this branch ↗︎ | |
…d improving visibility checks
…, hooks, nested tests, page events, and status codes. Update existing tests to improve structure and visibility checks.
…ptions, enhancing visibility checks and structure. Updated test descriptions for clarity and added new test cases for better coverage.
…nd adding new tests for enhanced coverage. Introduced a new file for commands to display in UI, and updated existing tests to improve structure and naming conventions.
…prove maintainability. This cleanup focuses on consolidating test cases and enhancing overall structure.
AtofStryker
requested changes
May 23, 2025
| }) | ||
|
|
||
| it('hooks', () => { | ||
| runSpec({ |
There was a problem hiding this comment.
instead of runSpec, can we leverage loadSpec with the correct num of 'pass/failed assertions to avoid thecypress:in:cypress:run:complete` event? That method should wait for the test to finnish
system-tests/project-fixtures/runner-specs/cypress/e2e/runner/ui-states/commands.cy.js
Outdated
Show resolved
Hide resolved
…e with parts 4, 5, and 6. Updated existing test descriptions for clarity and improved structure in the Cypress test suite.
AtofStryker
approved these changes
May 23, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 24, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 24, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 24, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 24, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 24, 2025
cypress-app-bot
pushed a commit
that referenced
this pull request
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Add a set of UI states that can be useful for snapshots when there're UI changes, ensuring the behavior persist
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?