chore(deps): update eslint to 7.32.0 #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ESLint 7 to CircleCI tests
|
jennifer-shehane
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
@MikeMcC399 Nice. I think an incremental approach is a great idea.
Thanks again for reviewing and merging! And thanks also for your vote of confidence in the Collaborator/Triage role! I did consider a "big-bang" update approach, however there are many complex interdependencies which are difficult to understand in one go. Putting all changes into one big PR would also be very difficult to review in-depth. So I have gone with the incremental approach and I'm happy with this so far! 🙂 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The repo is currently based on [email protected] released on Mar 30, 2019. This is an old version released 5 years ago and the repo needs to be moved towards compatibility with the current version ESLint
9.x.Changes
The repo base version is updated to [email protected] released on Jul 31, 2021. This version of ESLint is used for the Lint test in CircleCI. ESLint
7.xis an intermediate step in the journey towards supporting ESLint9.x.The following two modules are updated:
@cypress/[email protected](latest3.xrelease.)@cypress/[email protected](latest3.xrelease. (cypress-io/eslint-plugin-json is archived and therefore unsupported. This will be dealt with later.))v7.The equivalent npm package installation instructions used are:
Cross-version testing
On Ubuntu
22.04.4LTS, with Node.js20.12.2and with base version [email protected] installed, cross-version testing shows all tests passing. The symbol "+" indicates a successful test.