fix incorrect voronoi diagram for 5 collinear points #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide range of values of r (between 1e-11 and 1e-8)
mourner
approved these changes
Jul 12, 2024
mbostock
reviewed
Jul 13, 2024
mbostock
approved these changes
Jul 13, 2024
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #146 by adopting a simpler jittering strategy in the collinear case
Sharing for discussion, because this "fix" is really feeble: if we increase the radius a little bit more (to 5e-8), another test breaks. I'd like to find a more robust approach.Maybe at some point we'll need to create a fake voronoi diagram from scratch, rather than replay with jittered points, but it seems that this is working well enough for now.
closes #146