-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
gplazma: print selected JWT claims for failed logins
Motivation: We deliberately do not log bearer tokens. This follows security best- practice, because log files are not always as protected as they should be (e.g., copy-n-paste into a email or problem report), and this would leak the token. However, if an OIDC login fails and the bearer token is a JWT then there may be useful information in the JWT's payload that would help diagnose the problem. Modification: Update the LoginResultPrinter to identify bearer tokens that are JWT and add support for printing selected claims from the JWT's payload. Result: If there is a login failure involving a OIDC JWT then potentially important information is now extracted from the JWT and included in the logged login failure report. Target: master Request: 9.0 Request: 8.2 Require-notes: yes Require-book: no Patch: https://rb.dcache.org/r/13975/ Acked-by: Tigran Mkrtchyan
- Loading branch information
1 parent
bcf71f0
commit d096a5b
Showing
2 changed files
with
71 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters